From 04534792dd0610e3fe4e8b91262516f4ce7f4b5f Mon Sep 17 00:00:00 2001 From: David Vacca <515103+mdvacca@users.noreply.github.com> Date: Tue, 23 Jul 2024 20:57:01 -0700 Subject: [PATCH] Delete CoreFeatures class (#45626) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45626 I'm deleting CoreFeatures class and all its imports because it was fully replaced by ReactNativeFeatureFlags changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags Differential Revision: D60137380 --- .../Image/RCTImageComponentView.mm | 1 - .../ScrollView/RCTScrollViewComponentView.mm | 1 - .../Fabric/Mounting/RCTMountingManager.mm | 1 - .../react/fabric/FabricMountingManager.cpp | 1 - .../NativePerformanceObserver.cpp | 1 - .../renderer/components/image/ImageProps.cpp | 1 - .../textinput/BaseTextInputProps.cpp | 1 - .../components/view/ViewShadowNode.cpp | 1 - .../view/YogaLayoutableShadowNode.cpp | 1 - .../components/view/YogaStylableProps.cpp | 1 - .../events/EventPerformanceLogger.cpp | 1 - .../renderer/runtimescheduler/primitives.h | 1 - .../react/renderer/scheduler/Scheduler.cpp | 1 - .../ReactCommon/react/utils/CoreFeatures.cpp | 10 --------- .../ReactCommon/react/utils/CoreFeatures.h | 21 ------------------- 15 files changed, 44 deletions(-) delete mode 100644 packages/react-native/ReactCommon/react/utils/CoreFeatures.cpp delete mode 100644 packages/react-native/ReactCommon/react/utils/CoreFeatures.h diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm index 665b2979a79fff..d924d3ae4a2f2e 100644 --- a/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm +++ b/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm @@ -16,7 +16,6 @@ #import #import #import -#import using namespace facebook::react; diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm index 52618dd5dc9b09..7f9b7646510c23 100644 --- a/packages/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm +++ b/packages/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm @@ -20,7 +20,6 @@ #import #import -#include #import "RCTConversions.h" #import "RCTCustomPullToRefreshViewProtocol.h" #import "RCTEnhancedScrollView.h" diff --git a/packages/react-native/React/Fabric/Mounting/RCTMountingManager.mm b/packages/react-native/React/Fabric/Mounting/RCTMountingManager.mm index ec4354583ac04f..1cdf1fde34a658 100644 --- a/packages/react-native/React/Fabric/Mounting/RCTMountingManager.mm +++ b/packages/react-native/React/Fabric/Mounting/RCTMountingManager.mm @@ -20,7 +20,6 @@ #import #import #import -#import #import #import diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp index 17f96af88e8fc6..1e81d684446a57 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp +++ b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp @@ -19,7 +19,6 @@ #include #include #include -#include #include #include diff --git a/packages/react-native/ReactCommon/react/nativemodule/webperformance/NativePerformanceObserver.cpp b/packages/react-native/ReactCommon/react/nativemodule/webperformance/NativePerformanceObserver.cpp index 6ec448ad426b6e..65cb1a0b263f1a 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/webperformance/NativePerformanceObserver.cpp +++ b/packages/react-native/ReactCommon/react/nativemodule/webperformance/NativePerformanceObserver.cpp @@ -12,7 +12,6 @@ #include #include #include -#include #include "Plugins.h" diff --git a/packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.cpp b/packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.cpp index 255c9ad0c82532..6fed6d0b96d466 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.cpp @@ -9,7 +9,6 @@ #include #include #include -#include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/components/textinput/BaseTextInputProps.cpp b/packages/react-native/ReactCommon/react/renderer/components/textinput/BaseTextInputProps.cpp index ec0f350b5a4734..ecbb44e77fa34a 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/textinput/BaseTextInputProps.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/textinput/BaseTextInputProps.cpp @@ -21,7 +21,6 @@ #include #include #include -#include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp index b0d24f24d8f95f..e5272c82771c85 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp @@ -9,7 +9,6 @@ #include #include #include -#include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp index 5f8da4d5de5ea0..df9038a0e608f0 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/YogaStylableProps.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/YogaStylableProps.cpp index 508e3aeb6cac0a..f8839e11739d55 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/YogaStylableProps.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/YogaStylableProps.cpp @@ -11,7 +11,6 @@ #include #include #include -#include #include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/observers/events/EventPerformanceLogger.cpp b/packages/react-native/ReactCommon/react/renderer/observers/events/EventPerformanceLogger.cpp index 57f273ca1ac4c8..ace21dc90cf19f 100644 --- a/packages/react-native/ReactCommon/react/renderer/observers/events/EventPerformanceLogger.cpp +++ b/packages/react-native/ReactCommon/react/renderer/observers/events/EventPerformanceLogger.cpp @@ -8,7 +8,6 @@ #include "EventPerformanceLogger.h" #include -#include #include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/runtimescheduler/primitives.h b/packages/react-native/ReactCommon/react/renderer/runtimescheduler/primitives.h index 1531a99aa472fc..85cfd7f16792b1 100644 --- a/packages/react-native/ReactCommon/react/renderer/runtimescheduler/primitives.h +++ b/packages/react-native/ReactCommon/react/renderer/runtimescheduler/primitives.h @@ -9,7 +9,6 @@ #include #include -#include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp index 42169640ff9c55..3ddd7a7d0ccd9e 100644 --- a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp +++ b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp @@ -21,7 +21,6 @@ #include #include #include -#include #ifdef RN_SHADOW_TREE_INTROSPECTION #include diff --git a/packages/react-native/ReactCommon/react/utils/CoreFeatures.cpp b/packages/react-native/ReactCommon/react/utils/CoreFeatures.cpp deleted file mode 100644 index d0b3349ffce8d1..00000000000000 --- a/packages/react-native/ReactCommon/react/utils/CoreFeatures.cpp +++ /dev/null @@ -1,10 +0,0 @@ -/* - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - -#include "CoreFeatures.h" - -namespace facebook::react {} // namespace facebook::react diff --git a/packages/react-native/ReactCommon/react/utils/CoreFeatures.h b/packages/react-native/ReactCommon/react/utils/CoreFeatures.h deleted file mode 100644 index c4ab1fb5253b76..00000000000000 --- a/packages/react-native/ReactCommon/react/utils/CoreFeatures.h +++ /dev/null @@ -1,21 +0,0 @@ -/* - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - -#pragma once - -namespace facebook::react { - -/* - * Contains the set of feature flags for the renderer core. - * Some of them are temporary and may be eventually phased out - * as soon as the feature is fully implemented. - */ -class CoreFeatures { - public: -}; - -} // namespace facebook::react