From 86f2f42ef21c7abef7a99e98b4df67aa0821c637 Mon Sep 17 00:00:00 2001 From: Joseph Schuchart Date: Sat, 4 May 2024 09:05:49 -0400 Subject: [PATCH] Disable devel checks for PRRTE/PMIx The PRRTE and PMIx modules set `-Werror`, which has repeatedly led to builds of Open MPI breaking due to mere warnings that have otherwise no impact on correctness or performance. Warnings are tricky to catch since different compilers detect these minor issues with different precision. We do not control these code base and are merely consumers, so we should not accept third-party projects inhibiting our ability to build code inside a git repository. Signed-off-by: Joseph Schuchart --- config/ompi_setup_prrte.m4 | 2 ++ config/opal_config_pmix.m4 | 2 ++ 2 files changed, 4 insertions(+) diff --git a/config/ompi_setup_prrte.m4 b/config/ompi_setup_prrte.m4 index f690a749780..4b5a33c734a 100644 --- a/config/ompi_setup_prrte.m4 +++ b/config/ompi_setup_prrte.m4 @@ -164,6 +164,8 @@ AC_DEFUN([_OMPI_SETUP_PRRTE_INTERNAL], [ internal_prrte_CPPFLAGS= internal_prrte_args="--with-proxy-version-string=$OPAL_VERSION --with-proxy-package-name=\"Open MPI\" --with-proxy-bugreport=\"https://www.open-mpi.org/community/help/\"" + # PRRTE sets -Werror on devel builds so avoid buid breaks caused by 3rd-party codes + internal_prrte_args="$internal_prrte_args --disable-devel-check" # Set --enable-prte-prefix-by-default to the deprecated options, # if they were specified. Otherwise, set it to enabled if the diff --git a/config/opal_config_pmix.m4 b/config/opal_config_pmix.m4 index 8538ef576d2..bea801c335e 100644 --- a/config/opal_config_pmix.m4 +++ b/config/opal_config_pmix.m4 @@ -78,6 +78,8 @@ AC_DEFUN([OPAL_CONFIG_PMIX], [ # desired. internal_pmix_args="--without-tests-examples --enable-pmix-binaries --disable-pmix-backward-compatibility --disable-visibility" + # Open PMIx sets -Werror on devel builds so avoid buid breaks caused by 3rd-party codes + internal_pmix_args="$internal_pmix_args --disable-devel-check" internal_pmix_wrapper_libs= internal_pmix_CPPFLAGS=