Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMG performance tests #361

Open
sseraj opened this issue Aug 3, 2024 · 0 comments
Open

Add AMG performance tests #361

sseraj opened this issue Aug 3, 2024 · 0 comments
Labels
enhancement New feature or request maintenance This is for maintaining the repo

Comments

@sseraj
Copy link
Collaborator

sseraj commented Aug 3, 2024

Description of feature

The AMG tests only check if the flow and adjoint solvers converge. We should add tests to make sure the rates of convergence follow the expected trends when using different solver options.

There are some challenges to doing this. Our current regression testing infrastructure is not well-suited to testing performance. In addition, differences in performance might only show up on larger cases.

See #359 for some related discussion

@sseraj sseraj added enhancement New feature or request maintenance This is for maintaining the repo labels Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance This is for maintaining the repo
Projects
None yet
Development

No branches or pull requests

1 participant