Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links are no longer surfaced by anything #12076

Open
3 tasks done
Josh-Cena opened this issue Nov 2, 2024 · 2 comments
Open
3 tasks done

Broken links are no longer surfaced by anything #12076

Josh-Cena opened this issue Nov 2, 2024 · 2 comments
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@Josh-Cena
Copy link
Member

Summary

After #12045, there's nothing that helps us catch broken links.

URL

As one example: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers

Reproduction steps

Run yarn build

Expected behavior

Get a flaw for that page about "can't resolve Origin-Isolation"

Actual behavior

No flaws reported. Not only that, but because now Yari doesn't emit href for broken links any more, even my own https://jc-verse.github.io/mdn-graph/warnings cannot catch this. I'm considering whether I need to report all links with a.page-not-created but then I'll be unable to tell its possible location.

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Android

Screenshot

No response

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 2, 2024
@caugner
Copy link
Contributor

caugner commented Nov 4, 2024

From both a UX and SEO perspective, not linking to HTTP 404s is a significant improvement, but you make a good point.

I'm considering whether I need to report all links with a.page-not-created but then I'll be unable to tell its possible location.

What if we added the href back as data-href?

@Josh-Cena
Copy link
Member Author

Dure, that would work great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

2 participants