Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gridcell role to td #36968

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add gridcell role to td #36968

merged 2 commits into from
Nov 26, 2024

Conversation

timstallmann
Copy link
Contributor

Description

Adds a mention of the gridcell implicit ARIA role for for td elements which are descendants of role="grid".

Motivation

Gridcell is an ARIA-sub-role which applies to any cell elements within a grid (and, e.g. the w3 code sample for grid role all just use td elements with the explicit role), but MDN currently doesn't mention this on the td element descriptor page, which was confusing to me today when researching this. Hoping that adding this will make life a bit easier for future folks looking to implement a grid ARIA role.

Additional details

The ARIA description of gridcell as a subrole of cell applied when a cell is in a grid is linked here.

Related issues and pull requests

@timstallmann timstallmann requested a review from a team as a code owner November 25, 2024 19:47
@timstallmann timstallmann requested review from estelle and removed request for a team November 25, 2024 19:47
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed labels Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Preview URLs

(comment last updated: 2024-11-26 00:25:51)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Also, congratulations on your first merged MDN content PR. Welcome to the team!

@estelle estelle merged commit 7e044f5 into mdn:main Nov 26, 2024
8 checks passed
@timstallmann timstallmann deleted the tim/add-gridcell branch November 26, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants