Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAPI] Hide fragment directives from Navigation Timing API #36546

Open
8 tasks
Tracked by #596
hamishwillee opened this issue Oct 28, 2024 · 2 comments
Open
8 tasks
Tracked by #596

[WebAPI] Hide fragment directives from Navigation Timing API #36546

hamishwillee opened this issue Oct 28, 2024 · 2 comments

Comments

@hamishwillee
Copy link
Collaborator

hamishwillee commented Oct 28, 2024

Acceptance criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes for enabled/preview features
  • Add/remove entry to Firefox experimental features page for preference/released features

Features to document

This needs at least a release note because the behaviour is a bugfix that unfortunately some sites are relying on.
I would say a BCD entry too.

It may be reasonable to add a note to the preformance API thingy too that this is URL minus any url fragment (unrelated, but same behaviour might b recorded in https://developer.mozilla.org/en-US/docs/Web/API/Location/href

What happens is that if you use Performance.getEntries() (or the variants that take a name and type) you get an array of entries that have a particular requested type. One of the entry types is navigation so your objects are PerformanceNavigationTiming.

For these the name of each entry is a URL. The change is that now this URL will exclude the text fragment.

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1919565

Other

  • Check content open issues to see if any pertain to the subject matter. If there are any that can be closed because of the work, do so. If there are any that can be fixed relatively quickly because of the knowledge from completing this issue and you have time, feel free to go ahead and fix them.
@github-actions github-actions bot added Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 28, 2024
@hamishwillee hamishwillee added Firefox 133 and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 28, 2024
@eligrey
Copy link
Contributor

eligrey commented Oct 29, 2024

the behaviour is a bugfix that unfortunately some sites are relying on.

That is incorrect. This was not a bugfix prior to Firefox supporting scroll-to-text. Transcend shipped this feature long before Firefox shipped scroll-to-text support.

I reached out to @zcorpan for more engagement on these concerns. I believe it is unjust for Mozilla to retroactively classify breaking Transcend's features as a 'bugfix', given that there was no 'bug' when we first added the feature.

@zcorpan
Copy link
Contributor

zcorpan commented Oct 31, 2024

@eligrey it was a bug fix because the behavior didn't match what the spec requires.

I'm happy to discuss more, but this issue is not the right place. Please reach out to me directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants