Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary dependancy on ember-cli-update #38

Open
john-griffin opened this issue Mar 13, 2019 · 3 comments
Open

Unnecessary dependancy on ember-cli-update #38

john-griffin opened this issue Mar 13, 2019 · 3 comments

Comments

@john-griffin
Copy link

Just installed 0.3.0 and it seems to add an unnecessary dependancy on ember-cli-update. This was noticeable because we use yarn and the lock file had a huge diff. Seems to have been introduced in this PR #36 any reason for that?
@mdehoog
Copy link
Owner

mdehoog commented Mar 13, 2019

@RubenSmit any thoughts on this? Was added with martijnbolhuis@dfa52b8

@RubenSmit
Copy link
Contributor

Whoops, that's indeed an unnecessary dependancy used to aid with updating. It should have been removed.

@jrock2004
Copy link
Contributor

Any update on removing this as yarn audit is showing tons of moderate security issues with ember-cli-update dep of dep

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@john-griffin @jrock2004 @mdehoog @RubenSmit