New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove numericStringEquals? #36

Open

mdedetrich opened this issue Jul 5, 2017 · 1 comment

Owner

mdedetrich commented Jul 5, 2017

@sirthias argument #30 (comment)

mdedetrich changed the title ~~Remove numericStringEquals~~ Remove numericStringEquals?

mdedetrich mentioned this issue

Turns the standard AST JNumber into a safe constructor #30

Merged

Owner Author

mdedetrich commented Jul 5, 2017 •

edited

Loading

Also in response to this comment

The question of whether it's even feasible to properly do equality on arbitrary JSON numbers is a second issue. Is there a proper testsuite for the currently implemented "magic" equality implementation?

There is, you can see it in the various test folders in scalaJSON (i.e. https://github.com/mdedetrich/scalajson/blob/master/js/src/test/scala/specs/JNumber.scala and https://github.com/mdedetrich/scalajson/blob/master/jvm/src/test/scala/specs/JNumber.scala)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment