Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call tippyInstance.destroy? #134

Open
WofWca opened this issue Feb 1, 2021 · 0 comments · May be fixed by #135
Open

Call tippyInstance.destroy? #134

WofWca opened this issue Feb 1, 2021 · 0 comments · May be fixed by #135

Comments

@WofWca
Copy link

WofWca commented Feb 1, 2021

https://svelte.dev/docs#use_action says you can return an object with a destroy property.
Aren't we supposed to call the Tippy.js' destroy method there to avoid resource leaks?
@AndrewLester AndrewLester linked a pull request Feb 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add update and destroy to tippy action AndrewLester/sveltejs-tippy
1 participant
@WofWca