Update implementation for "Fix and prevent circular redirects new"

[Berdir]

See https://www.drupal.org/node/1796596

I committed an earlier version of the patch a while back: 3f11f06

We should update that according to the approach that was implented in 7.x-1.x (status and disable instead of delete I think, never really looked at the issue).

We should also check if other patches were committed and port what applies to the 8.x-1.x branch too.

[stefanruijsenaars]

I'll have a look at this later this week.

[turegjorup]

I'm testing Drupal 8.0 with the latest versions of pathauto (commit 54248b8) and redirect (commit f76170d).

Either module works independently, but when both are enabled I'm seeing a redirect loop on node creation and node edit.

I'm guessing that it relates to this issue so would really welcome a patch to this issue.

[Berdir]

I'm using those modules together and it is working for me, please provide exact steps to reproduce that loop.

8.x-1.x already has a minimal implementation for preventing the loop that this issue is about.

[turegjorup]

I have an existing D8 site we just updated from beta10 to 8.0 that allready has redirect enabled. When I add pathauto I see the redirect loop. If I un-install either module but keep the other enabled the problem goes away.

Found this issue as open, so havn't checked further than that.

I'll see if I can reproduce on a clean install of 8.0

[turegjorup]

Can't easily reproduce on a clean install of D8. Will report back if I find the problem / manage to reproduce.

[turegjorup]

Can't say if this is a new issue or it relates to this one. But I did figure out how to reproduce:

1. Download and install Drupal 8.0.0
   • drush pm-download drupal-8.0.0 --drupal-project-rename=htdocs
   • drush site-install standard
2. Enable redirect (commit f76170d)
3. Enable language module
4. Add danish as language and set it as default
   • Under Detection, select: URL, User in that order
   • Under URL, Configure: Select Path Prefix, Leave the path prefix for english to 'en', for Danish set it to an empty string

Now when adding content with a custom URL alias "Save and Publish" should trigger a redirect loop, but the node is actually created. Also just trying to access the content @ htttp//site/url_alias will trigger the redirect loop for logged in users, but not for anonymous users.

To fix the problem, under Language detection either:

• deselect User under Language detection
• set path prefix for danish to 'da' under URL

Uninstalling the redirect module also fixes the problem.