Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical Promise.race() fail #12

Open
kanongil opened this issue Nov 20, 2018 · 2 comments
Open

Critical Promise.race() fail #12

kanongil opened this issue Nov 20, 2018 · 2 comments

Comments

@kanongil
Copy link

kanongil commented Nov 20, 2018

Any usage of Promise.race() with more than 1 resolving promise triggers an exit!!

require('make-promises-safe');

Promise.race([Promise.resolve('a'), Promise.resolve('b')]);

setImmediate(() => console.log('done'));

Result:

resolve Promise { 'a' } b

Version: 3.0.0
Node: v10.13.0

@mcollina
Copy link
Owner

Good spot. I'll deprecate v2 and v3 immediately.

@BridgeAR
Copy link
Collaborator

@bmeurer we spoke about this at the diagnostics summit. Would you be so kind and give it another try to improve the functionality for multiple resolves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants