Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghcr.io Docker container generation to workflow actions #279

Open
cortices opened this issue Aug 6, 2023 · 2 comments
Open

Add ghcr.io Docker container generation to workflow actions #279

cortices opened this issue Aug 6, 2023 · 2 comments

Comments

@cortices
Copy link

cortices commented Aug 6, 2023

There's an open PR for improving the docker image size, which would be great to get merged.

But also it's difficult to deploy to any non-local server or kubernetes without a prebuilt image.

This page from github support has pretty much a ready-to-go example for adding docker image generation to workflows. Until then I'll be having to copy images manually over ssh to my server, which is not ideal.

@Johann150
Copy link
Collaborator

As noted in #144 (comment) I am still waiting for modifications to be made to that pull request. To clarify that I think that pull request is not complete I have marked it as a draft.

As noted in #145 (comment) I am not knowledgeable in Docker. If you want the thing you mentioned, feel free to open a pull request.

@cortices
Copy link
Author

cortices commented Aug 6, 2023

Thanks for the info.
For what it's worth, I've used @timwalls' Dockerfile in the past and it's been great, but his repo is now several years behind this one. I am happy to provide a PR that merges his version's more canonical approach to copying source, with the same directory and calling conventions as this repo's one, so as to reduce the likelihood of a breaking change. I will look at what is needed to get github actions to compile the image too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants