Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt support #24

Open
vytch opened this issue Oct 15, 2012 · 8 comments
Open

Grunt support #24

vytch opened this issue Oct 15, 2012 · 8 comments

Comments

@vytch
Copy link

vytch commented Oct 15, 2012

Hi

Your project rocks!
I would like to use that with grunt.
I know there is already a grunt-docco available.

Are you planning to work on grunt-docco-husky any time soon?

Thanks

Vytch

@adambiggs
Copy link

+1

@asciidisco
Copy link

The main problem with all of the docco - grunt modules out there is, that docco & docco-husky don´t export functions like 'normal' npm modules do. docco (and docco-husky) must be spawned.
Normally you want somthing that you can require & use in your node program:

var doccoHusky = require('docco-husky');
doccoHusky(myConfigurationObject);

So, before someone starts to build a docco-husky gruntplugin, docco-husky should export at least one function that
takes a configuration object & outputs the generated documentation. Anything else doesn´t make sense, in my humble opinion.

Conclusion, this issue shouldn´t be about grunt support in the first place, it should be about exporting an 'in Node' usable object or function.

@asciidisco
Copy link

I´ve seen that @vytch already implemented & pull requested this, shame on me for not checking the PRs ;)

@vytch
Copy link
Author

vytch commented Nov 4, 2012

Hi

yes I have done something, to make docco-husky compatible with grunt. I have tested it we can still use the module via command line.

But I think it needs more work around how the parameters can be added via a grunt file.
Also, it looks like the grunt-docco-husky module has an issue with yeoman (built on grunt) when used with the reload hook.

Vytch

@mbrevoort
Copy link
Owner

Been super busy. I'd like to take the pull request and make sure it's working with grunt and Yeoman and to @asciidisco 's point, I can certainly have the module.exports expose a single function.

@vytch
Copy link
Author

vytch commented Nov 4, 2012

Hi

I have done a first draft of a grunt-docco-husky.
https://github.com/vytch/grunt-docco-husky

I am currently testing it on a small personal project.
Vytch

@adambiggs
Copy link

Just curious, right now I'm using grunt-exec to run the docco-husky command. What are the advantages of using an actually grunt task instead of the CLI via grunt?

@vytch
Copy link
Author

vytch commented Nov 6, 2012

I did not know grunt-exec so thanks for sharing.

That question could be extended to a lot of tasks.
Maybe having a task makes the feature a bit easier to configure (using json instead of a string).

Now there is something I find a bit annoying, all grunt tasks have to be installed at the project level, and not globally.

The good thing about grunt exec is that I can install a node module globally and all my projects can use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants