Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework DSStore from perl to a Gradle task #71

Open
vlsi opened this issue Jul 17, 2020 · 5 comments
Open

Rework DSStore from perl to a Gradle task #71

vlsi opened this issue Jul 17, 2020 · 5 comments

Comments

@vlsi
Copy link

vlsi commented Jul 17, 2020

The current code is somewhat hard to follow, and it is not clear why arch -32 is needed:

arch -32 perl5.18 mpsdmg.pl "$(basename "$TMP_VOL_PATH")" "$VOLNAME" $(basename "$BG_PIC")

What if DS_Store generation was written in Java-based code?
For instance: https://formats.kaitai.io/ds_store/java.html

@vlsi
Copy link
Author

vlsi commented Jul 17, 2020

I see IntelliJ IDEA does not use arch -32: https://github.com/JetBrains/intellij-community/blob/c838dd4efbd00629f2a5874f336a324a04a8c141/platform/build-scripts/tools/mac/scripts/makedmg.sh#L81

@sergej-koscejev, do you by chance remember why arch -32 is used for perl5.18 mpsdmg.pl execution in mps-gradle-plugin?

@vlsi
Copy link
Author

vlsi commented Jul 17, 2020

An alternative approach migh be to reuse IDEA's build scripts.

For instance, they are still improved: JetBrains/intellij-community@c838dd4

@sergej-koscejev
Copy link
Member

Re arch -32: I copied the scripts over from mbeddr.core, I have no idea why it was used there. Here's relevant Git Blame for mbeddr.core: https://github.com/mbeddr/mbeddr.core/blame/a44cf0012dd573a403a5c340d65e02cebda2441d/buildUtil/mpsdmg.sh#L45

@sergej-koscejev
Copy link
Member

@vlsi is there a particular feature that's missing or not working? What motivated you to focus on this code?

@vlsi
Copy link
Author

vlsi commented Nov 22, 2020

@sergej-koscejev , AFAIK one of the issues is the current Perl script fails at GitHub Actions in macOS (e.g. https://github.com/mbeddr/mps-gradle-plugin/pull/70/checks?check_run_id=902243688 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants