[#2903] Refactor import/export for ZaakType configs #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
task/2903-import-export-zaaktype-config
branch
from
46e6e64 to
c4d1d34
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1503 +/- ##
===========================================
- Coverage 94.31% 94.25% -0.06%
===========================================
Files 1068 1068
Lines 40386 40457 +71
===========================================
+ Hits 38089 38133 +44
- Misses 2297 2324 +27 ☔ View full report in Codecov by Sentry. |
swrichards
requested changes
Dec 3, 2024
pi-sigma
force-pushed
the
task/2903-import-export-zaaktype-config
branch
4 times, most recently
from
476ab5a to
814eb49
Compare
pi-sigma
force-pushed
the
task/2903-import-export-zaaktype-config
branch
2 times, most recently
from
b3c97d0 to
1b099a9
Compare
pi-sigma
force-pushed
the
task/2903-import-export-zaaktype-config
branch
from
1b099a9 to
0a32b32
Compare
pi-sigma
force-pushed
the
task/2903-import-export-zaaktype-config
branch
from
0a32b32 to
f4f89ce
Compare
pi-sigma
changed the title
swrichards
approved these changes
Dec 4, 2024
src/open_inwoner/openzaak/admin.py
Outdated
| CatalogusConfigExport, | ||
| CatalogusConfigImport, | ||
| ) | ||
| from open_inwoner.openzaak.import_export import CatalogusConfigImport, ZGWConfigExport |
There was a problem hiding this comment.
I guess we could propagate the rename to the import container as well:
Suggested change
| from open_inwoner.openzaak.import_export import CatalogusConfigImport, ZGWConfigExport | |
| from open_inwoner.openzaak.import_export import ZGWConfigImport, ZGWConfigExport |
Comment on lines
+449
to
+461
| @admin.action(description=_("Export to file")) | ||
| def export_zaaktype_configs(modeladmin, request, queryset): | ||
| export = ZGWConfigExport.from_zaaktype_configs(queryset) | ||
| response = StreamingHttpResponse( | ||
| export.as_jsonl_iter(), | ||
| content_type="application/json", | ||
| ) | ||
| response[ | ||
| "Content-Disposition" | ||
| ] = 'attachment; filename="zgw-zaaktype-export.json"' | ||
| return response | ||
|
|
||
| def process_file_view(self, request): |
There was a problem hiding this comment.
The only thing that springs to mind is whether to do this as a mixin, given that there's non trivial logic here. But I would say we can add that to the technical debt list (because I think we might also want to add a Celery option given how long these imports take, but it shouldn't delay the current PR and patch release).
There was a problem hiding this comment.
Noted, I'll create a Taiga issue for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2903