Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable log level filtering on the TimelineLogAdmin page #1445

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

swrichards
Copy link
Contributor

@swrichards swrichards commented Oct 15, 2024

The log level is actually included in our timeline logger, although (mostly) the level defaults to INFO: that's something I'd like to start changing in future, but for now, we can actually already filter on logging level without adding a special flag, by using Postgres JSON field lookup functionality.

Screenshot from 2024-10-15 12-10-22

@swrichards swrichards force-pushed the swr/add-timeline-logger-level-filtering branch from 7c66783 to 2f8ee05 Compare October 15, 2024 10:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.57%. Comparing base (df9656f) to head (2f8ee05).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/open_inwoner/utils/admin.py 58.82% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1445      +/-   ##
===========================================
- Coverage    94.58%   94.57%   -0.01%     
===========================================
  Files         1069     1071       +2     
  Lines        39623    39720      +97     
===========================================
+ Hits         37478    37566      +88     
- Misses        2145     2154       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards requested a review from pi-sigma October 15, 2024 12:08
@swrichards swrichards marked this pull request as ready for review October 15, 2024 12:09
@swrichards swrichards marked this pull request as draft October 15, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants