Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#2625] Add skip-link design tokens #11

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jiromaykin
Copy link
Collaborator

@jiromaykin jiromaykin commented Oct 24, 2024

@jiromaykin jiromaykin force-pushed the feature/2625-skiplink-designtokens branch 2 times, most recently from fe52c61 to 76d9ac5 Compare November 4, 2024 15:38
@jiromaykin jiromaykin force-pushed the feature/2625-skiplink-designtokens branch from ea08ab0 to 8e90b82 Compare November 5, 2024 10:24
@jiromaykin
Copy link
Collaborator Author

@pi-sigma @swrichards This may not look very exciting, but this is the simple addition of a new design-token for a new tiny component.
The naming convention of these variables depend on the 'style-dictionary' NPM package and the NLDS variables naming conventions.
If you run this locally you should see this package will create a CSS file in the 'dist' folder.
This package version was published here: https://www.npmjs.com/package/@open-inwoner/design-tokens?activeTab=versions
So when approved, this means we can start using the updated version of this CSS in this other PR later on: maykinmedia/open-inwoner#1470

@jiromaykin jiromaykin merged commit ae0150e into main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants