Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple certificate manager remove it or implement it properly #477

Open
sjoerdie opened this issue Nov 18, 2024 · 1 comment
Open

Simple certificate manager remove it or implement it properly #477

sjoerdie opened this issue Nov 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working triage

Comments

@sjoerdie
Copy link
Contributor

Thema / Theme

Objecten API

Omschrijving / Description

If its in the admin I'm assuming it is supported?

1: Add private media to docker-compose to properly reflect persistence that is required since the certs are saved on /app/private-media/
2. Add sendfile settings so you can download certificates that have been uploaded, it will generate a 500 now. E.g. https://github.com/GeneriekPublicatiePlatformWoo/registratie-component/pull/132/files
3. Add --static-map /media=/app/private-media to uwsgi command in ./bin/docker_start.

Toegevoegde waarde / Added value

If its in the admin I'm assuming it is supported?

Aanvullende opmerkingen / Additional context

If its in the admin I'm assuming it is supported?

@sjoerdie sjoerdie added enhancement New feature or request triage labels Nov 18, 2024
@alextreme alextreme added bug Something isn't working and removed enhancement New feature or request labels Nov 18, 2024
@alextreme
Copy link
Member

To be discussed between Bart and Sjoerd. private-media shouldn't be exposed via uwsgi, this isn't safe because you will expose your private keys

@alextreme alextreme moved this from Triage to Todo in Data en API fundament Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
Status: Todo
Development

No branches or pull requests

3 participants