Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundler support #21

Open
cmhobbs opened this issue Jul 13, 2011 · 2 comments
Open

bundler support #21

cmhobbs opened this issue Jul 13, 2011 · 2 comments
Assignees
@cmhobbs
Labels
feature

Comments

@cmhobbs
Copy link
Collaborator

cmhobbs commented Jul 13, 2011

Add bundler to the project.
@ghost ghost assigned cmhobbs Jul 13, 2011
@maxjustus
Copy link
Owner

Big time. I'll try and set aside some time for this

@cmhobbs
Copy link
Collaborator Author

cmhobbs commented Aug 29, 2011

I've added bundler support to lib/sinatra-authentication.rb as seen in this commit: https://github.com/nilmethod/sinatra-authentication/commit/05b01aeb973897fa20ae812a719c7f15fe96e3a8

Does it make sense to add gems for all of the adapters supported to the Gemfile? I think that'd cause some unnecessary gems being installed on different systems. Should groups be established for gems pertaining to specific adapters? If so, how does that need to be handled when building the sinatra-authentication gem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmhobbs cmhobbs

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxjustus @cmhobbs