Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Google sing in session token not found in responses #83

Open
pabloascencao opened this issue Nov 14, 2016 · 11 comments
Open

Google sing in session token not found in responses #83

pabloascencao opened this issue Nov 14, 2016 · 11 comments

Comments

@pabloascencao
Copy link

I'm trying to use a google Api to log in my app but I want to do a double check in the BE. Googles documentation said that I'm able to do that if I send the encryted token id to the BE and stored it.

https://developers.google.com/identity/sign-in/web/sign-in

The main issue is that the response I get from this plugin doesn't have that token, Do you have any solution to that?

Thanks

@maximepvrt
Copy link
Owner

Hi,
Use can use GAuth. getToken()

I prepare also an update of this library to make it compatible with the new API gapi.auth2 (#40) and the new signup btn :)

@ruben-lopez
Copy link
Contributor

Hello maxime! I just want to know how much progress have you made on the gapi.auth2 functionality because @fernando-lopez and I have recently started to work on this too and maybe we are doing the same job :)

Best regards, Ruben.

@maximepvrt
Copy link
Owner

maximepvrt commented Nov 16, 2016

@EugeneZ
Copy link

EugeneZ commented Nov 28, 2016

Something to be aware of: The new gapi.auth2 API does not work when the "third party cookies" checkbox in Chrome is ticked, nor in Safari or Chrome's Private Browsing mode, or any other system where third party use of sessionStorage is limited. They have no plans to fix this. So if you upgrade it could actually cause more problems.

google/google-api-javascript-client#246

@fernando-lopez
Copy link

@maximepvrt Have you started to modify the fork?

@maximepvrt
Copy link
Owner

I work about that Yesterday. I would like to finish this week :)

@fernando-lopez
Copy link

@maximepvrt Do you have news about this update? We have been working in the code to add a signout button and we have discovered the pull request we have sent to you was wrong. Javascript auth2 library wasn't properly loaded.

In the code we send you we were loading oauth2 library instead auth2 (the name is pretty similar but it's not the right one.)

2017-01-04_18-50-38

We are currently working with a newer version with the right library and I don't know what is the best option,

A) We share with you the code with the library auth2 even if it's not finished yet. (I would say it's 50% percent done)

B) We wait for you version which will be more professional than us :)

@maximepvrt
Copy link
Owner

Hi,
🚨 In your pull request you are editing the dist folder, it's not a good solution. 😋
@fernando-lopez
I just published my work on the new version : https://github.com/maximepvrt/angular-google-gapi/tree/develop
But, it does not work yet ...
I want rewrite all of GAuth factory and delete GData factory

It's longer than expected

Example :
https://maximepvrt.github.io/angular-google-gapi-example/
https://github.com/maximepvrt/angular-google-gapi-example/

@fernando-lopez
Copy link

Hello Maxime,

We have been also working in your library.

We have a new version working fine without the GData and using Auth 2.0 Library.

Do you want do a pull request?

@maximepvrt
Copy link
Owner

ohh yess !

@fernando-lopez
Copy link

Puffff I have been having a look to your new code and it's already rather differnt than the version we have created, it's difficult to merge :(

I do the pull request and you evalute what is the best way.

Let me know if I can help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants