Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is possibility to break bound mod binding by mod update #744

Open
WSSDude opened this issue Nov 11, 2022 · 0 comments
Open

There is possibility to break bound mod binding by mod update #744

WSSDude opened this issue Nov 11, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@WSSDude
Copy link
Collaborator

WSSDude commented Nov 11, 2022

If mod previously registered hotkey with some id, and then later switches to use register input with same id, users end up with broken mod bindings.

There is no validation for bind code for inputs, only inside Binding widget code. So if there was previously hotkey assigned with more than one key, this switch would make binding not work (as it is not possible to press it then, cant really press 4 keys as one...)

Should be minor enough, as it can be rebound and it doesnt have any other sideeffects, but is there (for few CET version now... so would not call this a regression even)

@WSSDude WSSDude added the bug Something isn't working label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant