Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Improved UI feedback on mistyped character #75

Open
Sntx626 opened this issue Apr 6, 2023 · 3 comments
Open

[Feature Request] Improved UI feedback on mistyped character #75

Sntx626 opened this issue Apr 6, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Sntx626
Copy link

Sntx626 commented Apr 6, 2023

It would be great to have the option to only highlight mistyped characters, instead of whole words with mistyped characters in them.
This would mean only coloring the incorrect character, not the word.

Furthermore adding the option to show the mistyped character, instead of the intended-to-be-typed character, in the Prompt-Text-Area would allow the user to recognize what was typed incorrectly, not only where.
With this option enabled it could also be argued that the Input-Text-Field could be disabled since all feedback could exist inside the Prompt-Text-Area.

What do you think:

  • Is this even wanted? Or is relying on CTRL+BACKSPACE, without further feedback the intended use.
  • If there should be more UI feedback, how many options should be there?

I'm willing to start implementing these features but would like to check with you what you think about it first.

@bolphen
Copy link
Contributor

bolphen commented Jul 12, 2023

Here's one version that I've been using https://github.com/bolphen/ttyper/commit/c4a19803690de1a7fb85c6c4387af207e4b90401

A byproduct of marking individual characters is that it also fixes some issues mentioned in #77 (for example, accented letters like ä or é being counted as two characters).

@Sntx626
Copy link
Author

Sntx626 commented Aug 16, 2023

I wonder if this could be upstreamed, though I don't see a PR for that.

Is there interest for such a feature?

@bolphen
Copy link
Contributor

bolphen commented Sep 27, 2023

@Sntx626 Just made a PR. Though there's already another one #90 doing a similar thing.

@max-niederman max-niederman added the enhancement New feature or request label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants