Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there something that I should do? #74

Open
mawerty opened this issue Apr 10, 2023 · 8 comments
Open

Is there something that I should do? #74

mawerty opened this issue Apr 10, 2023 · 8 comments

Comments

@mawerty
Copy link
Owner

mawerty commented Apr 10, 2023

Is there something that I should do like better Readme, better contribution guidelines or something?

@mawerty mawerty changed the title Is there something that i should do? Is there something that I should do? Apr 10, 2023
@teub
Copy link

teub commented Apr 10, 2023

It would be a lot more safer if you add unit tests and continuous integration but I'm afraid it's a lot of work

@mawerty
Copy link
Owner Author

mawerty commented Apr 10, 2023

The problem is that I've never written unit tests, so I don't know how to do them, and the same goes for continuous integration. And second problem is that every PR is in different language so i would need to create something that can compile and test every language.

@teub
Copy link

teub commented Apr 10, 2023

If you had to pick just one language, Javascript is probably going to be the most used package

@PalmDevs
Copy link
Contributor

CI would be hell to setup 😅

@jeanlucaslima
Copy link
Contributor

  1. At least guarantee every code is responding false to any test against a number, some implementations are just "false"
  2. Create executable binaries to use as command line

@jeanlucaslima
Copy link
Contributor

One extra: a landing page using github to show it in action

@PalmDevs
Copy link
Contributor

  1. At least guarantee every code is responding false to any test against a number, some implementations are just "false"
  2. Create executable binaries to use as command line

That would require a single workflow to set up ALL THE THINGS to test. Unless we split workflows into one for each and every languages, which is doable.

@mawerty
Copy link
Owner Author

mawerty commented Apr 11, 2023

One extra: a landing page using github to show it in action

I pressed some random buttons and the page is now available here: https://mawerty.github.io/Is-Prime/ . I put link in About section. Should I put the link in Readme or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants