Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, unfortunately this algorithm is having some exception cases #37

Open
HJiashu opened this issue Apr 9, 2023 · 6 comments
Open

Hi, unfortunately this algorithm is having some exception cases #37

HJiashu opened this issue Apr 9, 2023 · 6 comments

Comments

@HJiashu
Copy link

HJiashu commented Apr 9, 2023

I checked 3, 5, 7, and 11. The algorithm is returning false.
I was hoping the authors would be willing to fix this. By maybe adding some if statements

@JosiahDub
Copy link

Do you have source(s) starting definitively that these numbers are prime? I don't want to dive down a rabbit hole based on a random issue.

@SreedevT
Copy link
Contributor

SreedevT commented Apr 9, 2023

Your test cases are very specific. There are other numbers you know. Try adding them to the test case and see the accuracy go up.. that's all that matters.

@jayar95
Copy link

jayar95 commented Apr 9, 2023

Works on my machine. Have you tried downloading more RAM?

@Acters
Copy link

Acters commented Apr 9, 2023

Realistically a failed test case means you already know it is a prime number. This code is accurate for ~95% from a certain variety of data. Theoretically this is similar to lim(x->∞) f(x) for ~100% accuracy. The more variety of data included, the more accurate the result is for the broad set.

@PalmDevs
Copy link
Contributor

PalmDevs commented Apr 10, 2023

Unfortunately, I cannot reproduce this issue on my 🚀 RTX 4090 Ti 🚀 bought by my ✨ AMERICAN EXPRESS PLATINUM CARD ✨ for some reason. Have you tried this on the 🚀 RTX 4090 Ti 🚀? If that still doesn't work, try with one bought by the ✨ AMERICAN EXPRESS PLATINUM CARD ✨. Thank you.

Let's be real for a second. We all don't have the RTX 4090 Ti, nor the American Express Platinum card.

@SreedevT
Copy link
Contributor

Unfortunately, I cannot reproduce this issue on my 🚀 RTX 4090 Ti 🚀 bought by my ✨ AMERICAN EXPRESS PLATINUM CARD ✨ for some reason. Have you tried this on the 🚀 RTX 4090 Ti 🚀? If that still doesn't work, try with one bought by the ✨ AMERICAN EXPRESS PLATINUM CARD ✨. Thank you.

Let's be real for a second. We all don't have the RTX 4090 Ti, nor the American Express Platinum card.

@Wwinter-Ttree might be of the poor variety in which case I might be able to represent. I tried to reproduce this in my athlon processor and it didn't show anything. Literally, nothing. I think it finally died. But hey I couldn't reproduce the test either that must mean it doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants