Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilation warnings due to missing storm32 feature #264

Open
danieleades opened this issue Aug 25, 2024 · 2 comments
Open

compilation warnings due to missing storm32 feature #264

danieleades opened this issue Aug 25, 2024 · 2 comments

Comments

@danieleades
Copy link
Contributor

danieleades commented Aug 25, 2024

There are compilation warnings on master due to missing storm32 feature.

The code-gen generates a storm32 cfg attribute, since this dialect is described in the mavlink message definitions, however Cargo.toml contains no such feature.

The warning should be addressed or suppressed.

warning: `mavlink-core` (lib) generated 1 warning
   Compiling mavlink v0.13.2 (/home/dan/Code/rust/rust-mavlink/mavlink)
warning: `mavlink-core` (lib test) generated 1 warning (1 duplicate)
warning: unexpected `cfg` condition value: `storm32`
 --> /home/dan/Code/rust/rust-mavlink/target/debug/build/mavlink-60b3f9a616716175/out/mod.rs:1:1960
  |
1 | ...:: unnecessary_cast)] # [allow (clippy :: bad_bit_mask)] # [cfg (feature = "storm32")] pub mod storm32 ; # [allow (non_camel_case_types)] # [allow (cl...
  |                                                                     ^^^^^^^^^^^^^^^^^^^
  |
  = note: expected values for `feature` are: `all`, `all-dialects`, `ardupilotmega`, `asluav`, `avssuas`, `common`, `cubepilot`, `default`, `development`, `direct-serial`, `embedded`, `embedded-hal-02`, `emit-description`, `emit-extensions`, `format-generated-code`, `icarous`, `matrixpilot`, `minimal`, `paparazzi`, `python_array_test`, `serde`, `slugs`, `standard`, `std`, `tcp`, `test`, `tokio-1`, `ualberta`, `uavionix`, and `udp`
  = help: consider adding `storm32` as a feature in `Cargo.toml`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: `#[warn(unexpected_cfgs)]` on by default
@pv42
Copy link
Contributor

pv42 commented Aug 25, 2024

#165 I think there is an issue with that dialect, thats why it is not included, so supressing would probably be a better solution.

@pv42
Copy link
Contributor

pv42 commented Aug 25, 2024

Looking further into it it seems like the problem is solved/deemded to be not a problem so maybe just adding the feature would actually be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants