allow to filter entries by title per subscription #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Hoß <[email protected]>
Signed-off-by: Sebastian Hoß <[email protected]>
|
@tulir sorry missed that there were lint errors - I hope that those are fixed now.. |
Signed-off-by: Sebastian Hoß <[email protected]>
|
Ok sorry again @tulir - third time's a charm? This time I installed all the tools and basically run the entire lint pipeline locally:
All checks are passing locally - sorry again for the inconvenience.. |
tulir
requested changes
Aug 30, 2024
Comment on lines
+111
to
+121
| if title_exclude_filter: | ||
| self.log.debug( | ||
| f"Feed '{feed.id}' ({feed.title}) has exclude filter '{title_exclude_filter}'" | ||
| ) | ||
| if re.search(title_exclude_filter, entry.title): | ||
| self.log.info(f"Excluded '{entry.title}'") | ||
| return None | ||
| else: | ||
| self.log.debug(f"Not excluding '{entry.title}'") | ||
| else: | ||
| self.log.debug(f"Feed '{feed.id}' ({feed.title}) has no exclude filter") |
There was a problem hiding this comment.
These logs should be .trace() instead of debug or removed entirely
| ) | ||
| @command.argument("feed_id", "feed ID", parser=int) | ||
| @command.argument("title_exclude_filter", "title exclude filter", pass_raw=True) | ||
| async def set_filter(self, evt: MessageEvent, feed_id: int, title_exclude_filter: str) -> None: |
There was a problem hiding this comment.
This should validate the filter before saving it (probably just re.compile)
| @@ -18,7 +18,7 @@ | |||
| upgrade_table = UpgradeTable() | |||
|
|
|||
|
|
|||
| @upgrade_table.register(description="Latest revision", upgrades_to=3) | |||
| @upgrade_table.register(description="Latest revision", upgrades_to=4) | |||
There was a problem hiding this comment.
You forgot to update the CREATE TABLE statement with the new column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6