Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AADev I see that repo is typesafe #235

Open
April-Bates-Dev opened this issue Aug 31, 2023 · 0 comments
Open

AADev I see that repo is typesafe #235

April-Bates-Dev opened this issue Aug 31, 2023 · 0 comments
Assignees
@April-Bates-Dev
Labels
enhancement New feature or request

Comments

@April-Bates-Dev
Copy link
Contributor

April-Bates-Dev commented Aug 31, 2023 •
edited
Loading

Description

We are using casting in multiple places in the repo. This runs the risk of introducing regressions as our code is not typesafe.

Tech steps

Replace casting with typeguards where appropriate.

Validation steps

Validation to be done by a developer- see ' as ' appearing minimally in the repo.
@April-Bates-Dev April-Bates-Dev self-assigned this Aug 31, 2023
@April-Bates-Dev April-Bates-Dev converted this from a draft issue Aug 31, 2023
@April-Bates-Dev April-Bates-Dev added the enhancement New feature or request label Aug 31, 2023
@April-Bates-Dev April-Bates-Dev moved this from Daily goals to In Progress in Code Review GPT Roadmap Aug 31, 2023
@April-Bates-Dev April-Bates-Dev moved this from In Progress to Code Review in Code Review GPT Roadmap Sep 1, 2023
@lizacullis lizacullis moved this from Code Review to Functional Review in Code Review GPT Roadmap Sep 4, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from Functional Review to To Validate in Code Review GPT Roadmap Sep 5, 2023
@aiden-walton aiden-walton moved this from To Validate to Done in Code Review GPT Roadmap Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@April-Bates-Dev April-Bates-Dev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@April-Bates-Dev