Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homebrew installation #73

Open
kevinburke opened this issue Sep 26, 2018 · 1 comment
Open

Homebrew installation #73

kevinburke opened this issue Sep 26, 2018 · 1 comment

Comments

@kevinburke
Copy link
Contributor

Support installation from Homebrew.
@kevinburke
Copy link
Contributor Author

from upstream:

go_resource are deprecated and are not acceptable in new formulae, please ask upstream to implement go vendoring.

Would you be open to vendoring dependencies here?

kevinburke added a commit to kevinburke/goreman that referenced this issue Sep 26, 2018
@kevinburke
Vendor all dependencies
3eb9444 
Updates mattn#73.
@kevinburke kevinburke mentioned this issue Sep 26, 2018
Merged
kevinburke added a commit to kevinburke/goreman that referenced this issue Sep 26, 2018
@kevinburke
Vendor all dependencies
24b7a00 
Updates mattn#73.
kevinburke added a commit to kevinburke/goreman that referenced this issue Sep 26, 2018
@kevinburke
Vendor all dependencies
10406ba 
Updates mattn#73.
kevinburke added a commit to kevinburke/goreman that referenced this issue Sep 26, 2018
@kevinburke
Vendor all dependencies
2d4b979 
Updates mattn#73.

Update the tests to wait for the WaitGroup, otherwise Go complains
you're reusing it before it's finished waiting for the previous group
to complete.
kevinburke added a commit to kevinburke/goreman that referenced this issue Sep 26, 2018
@kevinburke
Vendor all dependencies
d8ed73f 
Updates mattn#73.

Update the tests to wait for the WaitGroup, otherwise Go complains
you're reusing it before it's finished waiting for the previous group
to complete.
kevinburke added a commit to kevinburke/goreman that referenced this issue Sep 27, 2018
@kevinburke
Vendor all dependencies
3b4fed6 
Updates mattn#73.

Update the tests to wait for the WaitGroup, otherwise Go complains
you're reusing it before it's finished waiting for the previous group
to complete.
kevinburke added a commit to kevinburke/goreman that referenced this issue Sep 27, 2018
@kevinburke
Vendor all dependencies
819454e 
Updates mattn#73.

Update the tests to wait for the WaitGroup, otherwise Go complains
you're reusing it before it's finished waiting for the previous group
to complete.
kevinburke added a commit to kevinburke/goreman that referenced this issue Sep 29, 2018
@kevinburke
Vendor all dependencies
8bbf135 
Updates mattn#73.

Update the tests to wait for the WaitGroup, otherwise Go complains
you're reusing it before it's finished waiting for the previous group
to complete.
kevinburke added a commit to kevinburke/goreman that referenced this issue Oct 1, 2018
@kevinburke
Vendor all dependencies
106cf81 
Updates mattn#73.

Update the tests to wait for the WaitGroup, otherwise Go complains
you're reusing it before it's finished waiting for the previous group
to complete.
@kevinburke kevinburke mentioned this issue Oct 13, 2018
Closed
kevinburke added a commit to kevinburke/homebrew-core that referenced this issue Dec 12, 2018
@kevinburke
goreman 0.2.1 (new formula)
389dcb5 
Fixes mattn/goreman#73.
igas pushed a commit to Homebrew/homebrew-core that referenced this issue Dec 12, 2018
@kevinburke
goreman 0.2.1 (new formula)
ea2bcb5 
Fixes mattn/goreman#73.

Closes #32445.

Signed-off-by: Igor Kapkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinburke