Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect mean, std calculation in NSS calculation #12

Open
andrewbo29 opened this issue Jul 6, 2023 · 0 comments
Open

Incorrect mean, std calculation in NSS calculation #12

andrewbo29 opened this issue Jul 6, 2023 · 0 comments

Comments

@andrewbo29
Copy link

Hello!

Thank you for sharing the code. It seems that I found the bug in the calculation of NSS metric.
In https://github.com/matthias-k/DeepGaze/blob/main/deepgaze_pytorch/metrics.py#L41 mean, std should be changed to std, mean because of the output order in function https://pytorch.org/docs/stable/generated/torch.std_mean.html .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewbo29