From dcbb4b2a56c582537617e30ac23932796aa32daf Mon Sep 17 00:00:00 2001 From: ayusht2810 Date: Thu, 11 Apr 2024 17:18:00 +0530 Subject: [PATCH 1/2] Fix issue of button not disabled while adding todo without title --- webapp/src/components/add_issue/add_issue.jsx | 2 +- webapp/src/widget/buttons/button.tsx | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/webapp/src/components/add_issue/add_issue.jsx b/webapp/src/components/add_issue/add_issue.jsx index 3e521b85..963d9364 100644 --- a/webapp/src/components/add_issue/add_issue.jsx +++ b/webapp/src/components/add_issue/add_issue.jsx @@ -143,7 +143,7 @@ export default class AddIssue extends React.PureComponent { this.onKeyDown(e)} value={message} diff --git a/webapp/src/widget/buttons/button.tsx b/webapp/src/widget/buttons/button.tsx index 4110615a..bf2ac1a6 100644 --- a/webapp/src/widget/buttons/button.tsx +++ b/webapp/src/widget/buttons/button.tsx @@ -19,6 +19,7 @@ type Props = { danger?: boolean className?: string rightIcon?: boolean + disabled?: boolean } function Button(props: Props): JSX.Element { @@ -40,6 +41,7 @@ function Button(props: Props): JSX.Element { className={generateClassName(classNames)} title={props.title} onBlur={props.onBlur} + disabled={props.disabled} > {!props.rightIcon && props.icon} {props.children} From 005bc1e08efda3f1368880c0a988ab79366453a1 Mon Sep 17 00:00:00 2001 From: raghavaggarwal2308 Date: Sun, 21 Jul 2024 23:39:41 +0530 Subject: [PATCH 2/2] Review fix --- .vscode/settings.json | 3 +-- webapp/src/components/add_issue/add_issue.jsx | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index a143968c..e50d0ce4 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -37,8 +37,7 @@ "linux/dist/**": true, }, "editor.codeActionsOnSave": { - // "source.organizeImports": true, - "source.fixAll.eslint": true, + "source.fixAll.eslint": "explicit" }, "[typescriptreact]": { "editor.codeActionsOnSave": { diff --git a/webapp/src/components/add_issue/add_issue.jsx b/webapp/src/components/add_issue/add_issue.jsx index 963d9364..3e521b85 100644 --- a/webapp/src/components/add_issue/add_issue.jsx +++ b/webapp/src/components/add_issue/add_issue.jsx @@ -143,7 +143,7 @@ export default class AddIssue extends React.PureComponent { this.onKeyDown(e)} value={message}