Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-232] Update plugin with respect to phase 1 upgrades #244

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

ayusht2810
Copy link
Contributor

Summary

Updated plugin with respect to phase 1 upgrades

Ticket Link

@ayusht2810 ayusht2810 self-assigned this Feb 19, 2024
@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Feb 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 6.32%. Comparing base (3e3dae9) to head (8595a3c).

Files Patch % Lines
server/telemetry.go 0.00% 11 Missing ⚠️
server/plugin.go 0.00% 4 Missing ⚠️
server/configuration.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #244      +/-   ##
=========================================
- Coverage    6.42%   6.32%   -0.11%     
=========================================
  Files          11      10       -1     
  Lines        1712    1708       -4     
=========================================
- Hits          110     108       -2     
+ Misses       1594    1592       -2     
  Partials        8       8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister
Copy link
Contributor

mickmister commented Mar 14, 2024

@ayusht2810 Can you change the Go version in the Playwright test CI to 1.21 here? That test is failing currently because of the version mismatch

https://github.com/mattermost/mattermost-plugin-todo/blob/3e3dae93c6d9d7225a9d4da981b09b560577e16b/.github/workflows/playwright.yml#L13

@Kshitij-Katiyar
Copy link
Contributor

@ayusht2810 Can you change the Go version in the Playwright test CI to 1.21 here? That test is failing currently because of the version mismatch

https://github.com/mattermost/mattermost-plugin-todo/blob/3e3dae93c6d9d7225a9d4da981b09b560577e16b/.github/workflows/playwright.yml#L13

@mickmister Done and the Playwright test is working fine.

@mickmister mickmister merged commit 968b119 into master Mar 18, 2024
5 checks passed
@mickmister mickmister deleted the MM-232 branch March 18, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants