Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger menu gone and sidebar not able to be hidden #245

Open
Uatschitchun opened this issue Feb 24, 2024 · 7 comments
Open

Hamburger menu gone and sidebar not able to be hidden #245

Uatschitchun opened this issue Feb 24, 2024 · 7 comments
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/ReactJS Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@Uatschitchun
Copy link

Uatschitchun commented Feb 24, 2024

When clicking on one of the 3 icons in the bottom left for todos, the hamburger menu to hide the sidebar is gone and sidebar can't be hidden.

See attached pictures.
Screenshot_20240224_190323
Problem
Screenshot_20240224_185549_com opera browser
Screenshot_20240224_185555_com opera browser

@mickmister
Copy link
Contributor

Hi @Uatschitchun, thanks for filing this issue. It's a little difficult to tell what's going on here since the screenshots are so zoomed in. Is this occurring in the desktop browser? Would you be able to provide a gif of the issue occurring? I think that would be most helpful in this case. Thank you!

@Uatschitchun
Copy link
Author

Uatschitchun commented Feb 28, 2024

It's in browser mobile view, so not in desktop view. Try it out on smartphone.
Steps to reproduce:
When in a channel, opening the sidebar (hamburger menu top-left), there's a hamburger-menu on the top-right to close sidebar again.
With sidebar open click on one of the 3 todo-icons in the bottom-left and hamburger-menu (top-right) disappears. So no way to close sidebar

@mickmister
Copy link
Contributor

@Uatschitchun I understand what's going on now. When you click the plugin's items in the LHS, the plugin shows its RHS view, and clicking in that area does not make the channel browsing view slide back over. I've reproduced this with the GitHub plugin as well. Here's a gif reproducing with the todo plugin:

Screen.Recording.2024-02-29.at.7.41.45.AM.mov

@asaadmahmood Does anything need to change here other than ensuring that touching outside of the channel browsing pane should close it in this view?

@Uatschitchun
Copy link
Author

@mickmister Thx for the understanding and the gif!

@mickmister
Copy link
Contributor

@asaadmahmood When you have the chance can you take a look at my comment above?

@asaadmahmood
Copy link
Contributor

@mickmister Ideally, opening another window (like the todo, or github plugin) from the LHS should also close the LHS automatically as its opening something else.

@mickmister
Copy link
Contributor

@asaadmahmood Okay that makes sense. I wonder if it's possible for plugins to force close the LHS to make that happen. Maybe simulating a click when on mobile is all that needs to be done

@mickmister mickmister added Help Wanted Community help wanted Good First Issue Suitable for first-time contributors Difficulty/1:Easy Easy ticket Tech/ReactJS Up For Grabs Ready for help from the community. Removed when someone volunteers Type/Bug Something isn't working labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/ReactJS Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

3 participants