Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the RHS to send a ToDo shows no feedback if the target user has disabled ToDo #184

Open
DHaussermann opened this issue Sep 6, 2022 · 3 comments
Labels
Help Wanted Community help wanted Invalid This doesn't seem right Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@DHaussermann
Copy link

Using the RHS to send a ToDo shows no feedback if the target user has disabled ToDo. Sending via the slash command shows feedback that the user has blocked incoming ToDo but when a ToDo is created and assigned via the RHS the ToDo is simply not shown anywhere and the sender is not given any feedback about why.

Steps:

  • Login as a test user
  • Type /todo settings allow_incoming_task_requests off
  • Login as a 2nd user
  • Create a new ToDO from the RHS assigned to the 1st user
    Observed: ToDo save has no affect and ToDo is not visible anywhere
    Expected: The UI should also show feedback that the target user has blocked incoming ToDo the way the slash command does

Note: This is not a new issue. It occurs on current production v0.6.0

@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Sep 6, 2022
@catalintomai catalintomai added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Triage labels Sep 12, 2022
@pradeepmurugesan
Copy link

Hi.. Would like to take a shot on this one.

@pradeepmurugesan
Copy link

@DHaussermann couldn't reproduce the issue with the steps above. Getting a ping from the todo bot stating the user has blocked requests. Attaching screenshot.
Screenshot 2022-10-10 at 07 50 52

@DHaussermann DHaussermann added the Invalid This doesn't seem right label Oct 11, 2022
@DHaussermann
Copy link
Author

@pradeepmurugesan You're correct. I'm not sure how I missed this before or what build I may have been testing on.
On the latest build - I am seeing a DM from the bot when I click Save.
Thank you for bringing this to my attention 🎉

This is not ideal UX as it's not as obvious as feedback in the RHS but, the user does still get notified of the business logic.

I'm sorry for the invalid issue. Please ping if there's maybe another issue you would prefer to work on instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Community help wanted Invalid This doesn't seem right Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

3 participants