Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default TransactionRequest #787

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: default TransactionRequest #787

merged 2 commits into from
Dec 13, 2024

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented Dec 13, 2024 •
edited
Loading

What 💻

  • Fixes AnyNetwork::TransactionRequest::default() -> Zksync::TransactionRequest::default() to be constructed from alloy-zksync with the correct transaction_type.

Why ✋

  • AnyNetwork::TransactionRequest does not set the transaction_type and calling .into() will translate the same to Zksync::TransactionRequest

Evidence 📷

image

@nbaztec nbaztec requested a review from a team as a code owner December 13, 2024 11:08
@nbaztec nbaztec merged commit 68fcb7d into main Dec 13, 2024
23 checks passed
@nbaztec nbaztec deleted the nish-fix-create branch December 13, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jrigada Jrigada Jrigada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbaztec @Jrigada