Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing injection of factory deps #753

Merged
merged 7 commits into from
Dec 4, 2024
Merged

fix: Add missing injection of factory deps #753

merged 7 commits into from
Dec 4, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Nov 28, 2024

What 💻

  • Add missing injection of factory deps
  • Extend factory dependencies with nested factory dependencies of the injected one
  • Clear it afterwards

@Jrigada Jrigada requested a review from a team as a code owner November 28, 2024 19:49
@Jrigada Jrigada requested a review from nbaztec November 28, 2024 20:14
elfedy
elfedy previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@elfedy elfedy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
Karrq
Karrq previously approved these changes Nov 29, 2024
View reviewed changes
@Jrigada Jrigada dismissed stale reviews from elfedy and Karrq via e63800c November 29, 2024 13:20
@Jrigada Jrigada requested review from Karrq, elfedy and nbaztec November 29, 2024 13:24
@Jrigada Jrigada merged commit 2eb72ab into main Dec 4, 2024
12 checks passed
@Jrigada Jrigada deleted the fix-jrigada-add-missing-injection-fact-deps branch December 4, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfedy elfedy elfedy approved these changes

@Karrq Karrq Karrq approved these changes

@nbaztec nbaztec Awaiting requested review from nbaztec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jrigada @nbaztec @Karrq @elfedy