Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Test constructor function with and without values #749

Merged
merged 4 commits into from
Dec 2, 2024
Merged

test: Test constructor function with and without values #749

merged 4 commits into from
Dec 2, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Nov 28, 2024

What 💻

  • Add tests for constructor function in contracts with and without values

Why ✋

  • Values in constructors were not being passed and transferred to the contract.

@Jrigada Jrigada requested a review from a team as a code owner November 28, 2024 14:30
nbaztec
nbaztec previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@nbaztec nbaztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests always good :D

Karrq
Karrq reviewed Nov 29, 2024
View reviewed changes
crates/forge/tests/fixtures/zk/Constructor.s.sol Outdated Show resolved Hide resolved
testdata/zk/Constructor.t.sol Outdated Show resolved Hide resolved
testdata/zk/Constructor.t.sol Outdated Show resolved Hide resolved
@Jrigada Jrigada requested review from Karrq and nbaztec December 2, 2024 15:08
@Jrigada Jrigada merged commit 15b4758 into main Dec 2, 2024
12 checks passed
@Jrigada Jrigada deleted the test-constructor-with-value branch December 2, 2024 19:09
@Jrigada Jrigada mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karrq Karrq Karrq approved these changes

@nbaztec nbaztec Awaiting requested review from nbaztec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jrigada @nbaztec @Karrq