Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add Paymaster Params to transact #728

Merged
merged 8 commits into from
Nov 20, 2024
Merged

fix: Add Paymaster Params to transact #728

merged 8 commits into from
Nov 20, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Nov 15, 2024

What 💻

  • Added paymaster parameters to transact

Why ✋

  • For users without balance when executing a script that uses paymaster the simulation failed because instead of checking the paymaster balance we were getting the users balance.

@Jrigada Jrigada requested a review from a team as a code owner November 15, 2024 17:22
elfedy
elfedy reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor

@elfedy elfedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this by running a script and checking simulations with paymaster work?

Karrq
Karrq previously approved these changes Nov 16, 2024
View reviewed changes
Karrq
Karrq reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Karrq Karrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I previously approved because everything else LGTM, but yeah we should have a test for this

@Karrq Karrq self-requested a review November 18, 2024 09:39
@Karrq Karrq dismissed their stale review November 18, 2024 09:39

Needs test

Karrq
Karrq previously approved these changes Nov 20, 2024
View reviewed changes
crates/forge/tests/it/zk/paymaster.rs Outdated Show resolved Hide resolved
@Jrigada
Follow standard of installing libs for scripts
7b99951
@Jrigada
Merge branch 'fix-jrigada-simulation-fail-zero-balance-with-paymaster…
7706b63 
…' of github.com:matter-labs/foundry-zksync into fix-jrigada-simulation-fail-zero-balance-with-paymaster
@Jrigada Jrigada requested review from Karrq and elfedy November 20, 2024 12:40
@Jrigada Jrigada merged commit 420660c into main Nov 20, 2024
12 checks passed
@Jrigada Jrigada deleted the fix-jrigada-simulation-fail-zero-balance-with-paymaster branch November 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karrq Karrq Karrq approved these changes

@elfedy elfedy Awaiting requested review from elfedy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jrigada @Karrq @elfedy