Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler:zk): zksolc 1.5.7 #688

Merged
merged 5 commits into from
Nov 4, 2024
Merged

feat(compiler:zk): zksolc 1.5.7 #688

merged 5 commits into from
Nov 4, 2024

Conversation

Karrq
Copy link
Contributor

@Karrq Karrq commented Nov 1, 2024

What 💻

  • codegen setting
  • output_selection no longer optional

Why ✋

  • zksolc 1.5.7 added a new option
  • and also now requires all fields in output_selection to be specified

Notes 📝

@Karrq
fix(compiler:zk): non-opt OutputSelection
32c275d 
fix(compiler:zk): `codegen`
@Karrq Karrq added compiler 📟 Issues specific to compiling needs review 👓 PR requires a review labels Nov 1, 2024
@Karrq Karrq self-assigned this Nov 1, 2024
@Karrq Karrq marked this pull request as ready for review November 1, 2024 19:31
@Karrq Karrq requested a review from a team as a code owner November 1, 2024 19:31
@Karrq Karrq merged commit 953a180 into main Nov 4, 2024
17 checks passed
@Karrq Karrq deleted the feat/zksolc-1.5.7 branch November 4, 2024 13:29
@Karrq Karrq mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfedy elfedy elfedy approved these changes

Assignees

@Karrq Karrq

Labels
compiler 📟 Issues specific to compiling needs review 👓 PR requires a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karrq @elfedy