Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zk): create with either bytecode #631

Merged
merged 5 commits into from
Oct 26, 2024
Merged

fix(zk): create with either bytecode #631

merged 5 commits into from
Oct 26, 2024

Conversation

Karrq
Copy link
Contributor

@Karrq Karrq commented Oct 22, 2024

What 💻

  • Lookup dual compiled contract for both types
  • Refactor vm::create args

Why ✋

  • To correctly handle low level create calls with zk bytecode
  • To better encode the necessary function call requirements

Evidence 📷

IMG_2158

@Karrq Karrq requested a review from a team as a code owner October 22, 2024 20:49
nbaztec
nbaztec previously approved these changes Oct 22, 2024
View reviewed changes
@Karrq
chore: lifetime lint
2f6046a 
deps: remove unused dep
@Karrq Karrq requested a review from nbaztec October 23, 2024 19:50
@Karrq Karrq merged commit f17912e into main Oct 26, 2024
11 checks passed
@Karrq Karrq deleted the fix/zk-create-bytecode branch October 26, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbaztec nbaztec nbaztec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karrq @nbaztec