Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add solc artifacts to known contracts for traces #572

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix: add solc artifacts to known contracts for traces #572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a192bb5
add solc artifacts to known contracts for traces
nbaztec Sep 13, 2024
0d4e935
Merge branch 'main' into nish-add-solc-known-contracts
nbaztec Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/forge/src/multi_runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,12 @@ impl MultiContractRunnerBuilder {
warn!("Abi not found for contract {}", id.identifier());
}
}

// Extend zk contracts with solc contracts as well. This is required for traces to
// accurately detect contract names deployed in EVM mode, and when using
// `vm.zkVmSkip()` cheatcode.
zk_contracts_map.extend(linked_contracts);

known_contracts = ContractsByArtifact::new(zk_contracts_map);
}

Expand Down