Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't prevent scrolling on iOS 10 Safari #326

Open
breville opened this issue Jul 28, 2017 · 3 comments
Open

Doesn't prevent scrolling on iOS 10 Safari #326

breville opened this issue Jul 28, 2017 · 3 comments
Labels
Bug events IOS Safari
Milestone
New Event Model

Comments

@breville
Copy link

This code doesn't appear to prevent scrolling the page on iOS Safari. From some quick debugging, the most likely explanation is that it binds its touchMove handler during its touchStart handler, leading Safari to not call the touchMove handler until after a finger is released from the drag action. If it were to bind its touchMove handler before the touch begins, then the touchMove handler is called immediately, and scrolling can be prevented.
@italomandara
Copy link

Same here, in my case the swipe event is also not fired

sebikeller pushed a commit to sebikeller/TouchSwipe-Jquery-Plugin that referenced this issue Oct 4, 2017
Fixing scrolling issue in Safari for iOS
ab9cd1e 
Implemented fix proposed in mattbryson#326 .
Works like a charm, thx @breville !

¡¡¡¡ Further work required !!!!
====================
* test on other mobile browsers (Android)
* update minified file as well
@sebikeller sebikeller mentioned this issue Oct 4, 2017
Open
@mattbryson
Copy link
Owner

Will look into this as part of the next release that re works the event model

@mattbryson mattbryson added this to the New Event Model milestone Sep 17, 2018
@indreksiitan
Copy link

Any idea when the next release might be happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug events IOS Safari
Projects
None yet
Milestone
New Event Model
Development

No branches or pull requests
4 participants
@indreksiitan @mattbryson @breville @italomandara