Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

[Menu]: Hoist To Body property isn't reactive #335

Open
kfirba opened this issue Jul 14, 2019 · 2 comments
Open

[Menu]: Hoist To Body property isn't reactive #335

kfirba opened this issue Jul 14, 2019 · 2 comments
Labels

Comments

@kfirba
Copy link
Contributor

kfirba commented Jul 14, 2019

Describe the bug
When we set the hoist-to-body prop to be dynamic based on some other property it only works when the value changes to true. If the initial value is false and then we change the value to true we do get the desired behavior and the menu is being hoisted to the body.

However, when the value is true and we change it to false, the menu does not get "de-hoisted" back to where it initially was in the DOM. This might not be possible with the way MDC web works but according to their docs there is setIsHoisted() method which accepts a boolean and leads me to believe that a menu can be de-hoisted.

To Reproduce
Steps to reproduce the behavior:

  1. create a menu with hoisted-to-body prop bounded to a reactive data hoistMenu: false
  2. Change hoistMenu to true, the menu should be hoisted now.
  3. Change hoistMenu back to false and the menu is not being de-hoisted

Expected behavior
What I expect to happen is that the menu will be re-rendered in its proper spot in the DOM.

@tychenjiajun
Copy link
Contributor

Thank you for reporting! PR is welcomed.

@tychenjiajun
Copy link
Contributor

There is no getter for isHoisted. So I think the best way to address this issue is to add a method setIsHoisted and allow user to call it using Vue refs, at the same time make hoisted-to-body deprecated. This will be a breaking change so it's better to introduce it later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants