Skip to content
This repository has been archived by the owner on Oct 8, 2023. It is now read-only.

Omit update check by default #9

Closed
x29a opened this issue Dec 11, 2020 · 2 comments
Closed

Omit update check by default #9

x29a opened this issue Dec 11, 2020 · 2 comments

Comments

@x29a
Copy link
Contributor

x29a commented Dec 11, 2020

Hey,

what is your opinion on omitting the flutter update check on startup?

Id argue that since the container is disposed after each call, manual upgrading doesnt make any sense and the update check takes quite a while on each run.

This would also contribute towards #5 for faster container startup times.

The appropriate flag is --no-version-check (see here).

After all, the flutter upgrade call works nevertheless if people need it (e.g. for persistent containers).

@matsp
Copy link
Owner

matsp commented Jan 3, 2021

Sounds like a good idea ☺️

@x29a
Copy link
Contributor Author

x29a commented Jan 4, 2021

Ill send in the PR soon then, thanks for your feedback!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants