Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private projects are being shown on Start Page #76

Closed
billyc opened this issue Dec 5, 2018 · 5 comments
Closed

Private projects are being shown on Start Page #76

billyc opened this issue Dec 5, 2018 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@billyc
Copy link
Collaborator

billyc commented Dec 5, 2018

All projects and viz seem to be showing up on the Start Page, regardless of whether the project is marked as "public" or "private".

@billyc billyc added the bug Something isn't working label Dec 5, 2018
@Janekdererste
Copy link
Member

Janekdererste commented Dec 5, 2018

This is related to matsim-org/viz-server#64
The endpoint behaves not as expected. It either returns personal or public projects depending on the presented authentication

@Janekdererste
Copy link
Member

Question is, should the start page only show public projects? Start Page and Projects Page both query the same endpoint at the moment. If the Projects Page goes away eventually, it would make sense to show public and private projects on the StartPage if the user is logged in and only public ones when not.

If we keep things separated it could also make sense to only show public projects on the start page and only personal ones in the project page

@billyc billyc added this to the m1 milestone Dec 6, 2018
@billyc
Copy link
Collaborator Author

billyc commented Feb 13, 2019

@Janekdererste - Ah, this already exists. I proposed a change to the FileAPI in #97 such that you can separate requests for public visualizations from requests for "my" projects. I don't think one API call should do both things, do you?

This looks worse now in the UI, because I'm merging the Projects page and the Start page. See #98

@billyc billyc self-assigned this Feb 13, 2019
@billyc billyc modified the milestones: m1, m0 Feb 13, 2019
@billyc
Copy link
Collaborator Author

billyc commented Mar 6, 2019

See #97

@billyc billyc modified the milestones: m0, m1 Mar 7, 2019
@Janekdererste
Copy link
Member

This is no longer true. There is no public projects section right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants