This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
CI run against latest deps is failing #16100
Labels
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Comments
Oh, this has been failing for three weeks.
We might need to suppress redundant casts like we do in the twisted trunk job---but there's more going on here. |
...that was the wrong issue |
DMRobertson
added
the
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
label
Aug 29, 2023
The redundant cast is synapse/synapse/handlers/initial_sync.py Line 203 in 41f127e
which mypy can deduce for itself using the latest twisted annotations. If we make mypy ignore the redundant cast, or remove the cast entirely, then it passes. So I think the extra complains that mypy makes are false positives---something to do with mypy's overload resolution? Fix is to port over the ignore-redundant-casts change from #16121 Later, when we bump the lockfile to use the latest twisted, we can remove the cast entirely. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
See https://github.com/matrix-org/synapse/actions/runs/6026417807
The text was updated successfully, but these errors were encountered: