From a377e7c9b662d930bec2ac82499212952c02ac53 Mon Sep 17 00:00:00 2001 From: Mikhail Aheichyk Date: Tue, 19 Sep 2023 11:17:58 +0300 Subject: [PATCH] Code review changes Signed-off-by: Mikhail Aheichyk --- src/utils/membership.ts | 1 - test/utils/membership-test.ts | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/utils/membership.ts b/src/utils/membership.ts index 6d20f40bb76..df012e442b6 100644 --- a/src/utils/membership.ts +++ b/src/utils/membership.ts @@ -69,7 +69,6 @@ export function getEffectiveMembership(membership: string): EffectiveMembership if (membership === "invite") { return EffectiveMembership.Invite; } else if (membership === "join" || (SettingsStore.getValue("feature_ask_to_join") && membership === "knock")) { - // TODO: Include knocks? Update docs as needed in the enum. https://github.com/vector-im/element-web/issues/14237 return EffectiveMembership.Join; } else { // Probably a leave, kick, or ban diff --git a/test/utils/membership-test.ts b/test/utils/membership-test.ts index 07479c45060..3561625573e 100644 --- a/test/utils/membership-test.ts +++ b/test/utils/membership-test.ts @@ -21,8 +21,7 @@ import { isKnockDenied, waitForMember } from "../../src/utils/membership"; import { createTestClient, mkRoomMember, stubClient } from "../test-utils"; describe("isKnockDenied", () => { - // const userId = MatrixClientPeg.get()!.getSafeUserId() //TODO: MA - const userId = "some"; + const userId = "alice"; let client: jest.Mocked; let room: Room;