Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At least one dependency doesn't support ES modules #4317

Open
lukasz-zaroda opened this issue Jul 20, 2024 · 2 comments
Open

At least one dependency doesn't support ES modules #4317

lukasz-zaroda opened this issue Jul 20, 2024 · 2 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@lukasz-zaroda
Copy link

It looks like this package doesn't fully support ESM because at least one of its dependencies doesn't support it. I mean sdp-transform here. Maybe for bundlers it doesn't matter, but it's impossible to use this lib in a pure ESM environment, like with a Symfony's AssetMapper.
@dosubot dosubot bot added the T-Defect label Jul 20, 2024
@dbkr dbkr added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jul 22, 2024
@richvdh
Copy link
Member

richvdh commented Jul 22, 2024

Isn't #4287 more of a problem for an ES environment?

@lukasz-zaroda
Copy link
Author

Isn't #4287 more of a problem for an ES environment?

Possibly. I couldn't even require this library in AssetMapper, though, because it failed on the sdp-transform library when figuring out dependencies, so it's possible that even if sdp-transform would not be a problem, I would stumble on something else later. These issues are not mutually exclusive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbkr @richvdh @lukasz-zaroda