Modules using a variable binding to logger.log do not respect logger.setLevel

[davidisaaclee]

Issue

I'm getting noisy logs from this library despite setting loglevel.getLogger("matrix").disableAll().

Cause

matrix-js-sdk/src/models/event-timeline-set.ts

Lines 30 to 38 in acbcb46

	/* istanbul ignore next */
	let debuglog: (...args: any[]) => void;
	if (DEBUG) {
	// using bind means that we get to keep useful line numbers in the console
	debuglog = logger.log.bind(logger);
	} else {
	/* istanbul ignore next */
	debuglog = function (): void {};
	}

matrix-js-sdk/src/timeline-window.ts

Line 34 in acbcb46

const debuglog = DEBUG ? logger.log.bind(logger) : function (): void {};

loglevel applies setLevel by replacing the relevant methods on the logger object: https://github.com/pimterry/loglevel/blob/f0187213feb6495630545a34a3b91633db47a1ee/lib/loglevel.js#L86-L97

If debuglog binds logger.log at the time of module load, debuglog will not be updated to respect setLevel. This causes noisy logs in my application even when running loglevel.getLogger("matrix").disableAll().

Possible fixes

1. Use logger.log directly instead of debuglog. I don't understand why the library is disabling debuglog based on the local DEBUG constant, but I bet this could be achieved with loglevel's setLevel.
2. Forfeit line numbers and use a reference to logger.log (e.g. const debuglog = (...args) => logger.log(...args))
3. Some galaxy-brain Proxy implementation that I wasn't able to achieve (feel like there's a solution here that would keep the current DEBUG behavior and get line numbers with logs)

I've implemented option 1 in my branch: davidisaaclee@9849818

Please let me know if there's a better way to get these changes moving than filing Github issues – it seems like you have a lot on your plate, and I'd like to help in an effective way.

[vractal]

have you tried logger.disableAll()? seems to work here

[davidisaaclee]

@vractal I haven't, but that would prevent me from using my own logger instances, right?