Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach higher-level abstractions to events earlier #254

Open
kegsay opened this issue Oct 24, 2016 · 0 comments
Open

Attach higher-level abstractions to events earlier #254

kegsay opened this issue Oct 24, 2016 · 0 comments

Comments

@kegsay
Copy link
Member

kegsay commented Oct 24, 2016

If you listen for 'event', the sender/target properties will not be set on them as they only get set in the context of a Room (where the list of RoomMembers can be extracted). This is mainly because we're creating new MatrixEvents for 'event' emissions, rather than reusing the ones we passed to the Room objects. If they were shared, they would magically have the correct properties. We need to be careful when explaining how this works without a store though (no store = no Room context = no sender/target properties on raw 'event' emissions).

https://matrix.org/jira/browse/SYJS-14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants