-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The upper/lower case of parameter values are lost, not expected for "Campaign IDs" parameters like mtm_cid or utm_id #27
Comments
I'm not sure what you mean by "it becomes invalid"? |
It will be invalid for Google. The variable is used to report offline results of campaigns back to Google. Google can't match the click if the variable isn't case-sensitive. |
Sorry @sesom42 you will have to help me here a bit. I'm not so much into it and not fully understand. Which variable do you refer to? The |
@tsteur I might be wrong, but I think they mean the ID is something like |
I see. This might be done here: https://github.com/matomo-org/plugin-MarketingCampaignsReporting/blob/3.1.1/Campaign/CampaignDetector.php#L86 @sgiehl do you maybe remember why that is? |
Hey guys, any news on that issue? The gclid are lowercased and invalid for Google Offline Conversions. |
@sgiehl do you maybe know more here? |
Actually I don't think there is a good reason for doing so. I suggested a possible solution here: #65 (comment) |
I don't think there would be an alternative way except of patching the two files according to my pull request. I extended data collection with a parameter mtm_clid (not mtm_cid) for case-sensitive collection. I hoped, this PR would find a way into the core of MCR but for now, I'm patching up to 5 different matomo-instances every time an update of MCR is released. |
@chopsol thanks Joachim! |
As a follow up to #65, wouldn't it additionally make sense to apply "Case sensitive" to the whole of
|
@mattab As discussed on the PR it would actually make sense to give the user the choice to decide if any of the campaign parameters should be handled case sensitive or not. I think I suggested that on the PR already. We imho should make all parameters case sensitive, so remove the strtolower in tracking. The reports could than have an additional option to group all values either case insensitive or not. I think that would give everyone the most flexibility. But that is something that needs to be applied to core and this plugin. |
A Cloud customer cannot needed to track a case-sensitive campaign ID for offline reporting, but due to forced lower-case letters, there was not way to match their data. |
We use pk_content to store the Google click ID. This variable is case sensitive. Unfortunately the plugin does not save the variable case sensitive and it becomes invalid.
The text was updated successfully, but these errors were encountered: